Add Plex play_media logging and troubleshooting tools#34412
Merged
Conversation
This was referenced Apr 21, 2020
2b429d5 to
2ac4f32
Compare
MartinHjelmare
approved these changes
Apr 22, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Good!
If you have time, please update the developer docs to mention this option. 👍
jjlawren
added a commit
to home-assistant/developers.home-assistant
that referenced
this pull request
Apr 22, 2020
Contributor
Author
|
Dev docs PR: home-assistant/developers.home-assistant#470 |
MartinHjelmare
pushed a commit
to home-assistant/developers.home-assistant
that referenced
this pull request
Apr 23, 2020
balloob
pushed a commit
that referenced
this pull request
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Many of the issues raised for the Plex component relate to the
media_player.play_mediaservice and (usually silent) failures. Many of these failures are networking setups or lack of client support, but it's always difficult to be certain. This PR adds a few things to improve troubleshooting abilities:plexapilibrary when media lookup fails.media_content_typenamed "KEY". Instead of the existing escaped JSON required formedia_content_id, this allows a user to specify a plain integer associated with the media by the Plex server. This can be found via Plex Web by going to Get Info -> View XML on the media and looking forratingKey.Existing style:
"Key" style:
I do not intend to document the "key" style at the moment as its use is currently intended for troubleshooting purposes. However, this could become useful in the future if home-assistant/architecture#331 is implemented.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
The integration reached or maintains the following Integration Quality Scale: